node-sdk

node-sdk copied to clipboard

Improvements

9

Potential improvements discovered during #87 but not blocking its merge: - [x] github action [slack notification like we had in travis](https://github.com/transloadit/node-sdk/blob/9bb622ebbedb67fab4fc618679f3bbe2b339e592/.travis.yml#L11) - [x] Use github releases with release notes instead...

mifi

re-enable scheduled tests

1

until we can implement a localtunnel replacement, I disabled the scheduled tests in https://github.com/transloadit/node-sdk/commit/90cdfc6d69584cedbafd88058159c177fea5f34f in order to reduce noise. need to re-enable https://github.com/transloadit/node-sdk/issues/89#issuecomment-1194003057

mifi

WIP: Support Credential API

1

Not ready yet, just trying to see if i can get basic interaction working. Also see - https://transloadit.slack.com/archives/C034DS4B1/p1657800061383759 - https://github.com/transloadit/terraform-provider-transloadit/issues/32

kvz

Prevent job failure on scheduled job

3

The daily test job fails sporadically due to timeout. https://github.com/transloadit/node-sdk/actions/runs/629088395 - [ ] Maybe retry the whole job

mifi

Recreating pr #144 mostly as a TODO for the future. Note: Don't merge yet because it's a breaking change.

mifi

upgrade to yarn 4

1

Note: breaking change (requires node>=18) TODO - [ ] replace np with something that works with yarn 4 (and update readme) #169

mifi

This reverts commit 6c5afcee12b0784c8ba0fa757bb0aa97b73ef231. merge this once eventual consistency https://github.com/transloadit/node-sdk/issues/142#issuecomment-1201565496 has been resolved

mifi

It does not support yarn 4, and has [no plans](https://github.com/sindresorhus/np/issues/612) to support it either. Meanwhile, i find 4 is a massive speed boost. It's so fast on subsequent runs that...

kvz

if i make a mistake updating a Template that in fact does not exist, i only see: ``` HTTPError: Response code 400 (Bad Request) at Request. (node_modules/got/dist/source/as-promise/index.js:118:42) at process.processTicksAndRejections (node:internal/process/task_queues:95:5)...

mifi

- Browsers - React Native? Maybe also rename to `transloadit-js-client` then we could use it also in [Uppy](https://uppy.io/)

mifi