Removed depricated code

Open shahidikram0701 opened this issue 8 years ago • 5 comments

Oct 15 '17 16:10 shahidikram0701

Sorry for only getting to this now.

I currently have Translate Toolkit 2.4.0, and the existing code (with extractpoline) still works. Is it just deprecated, or was the removal reversed? Do we still need this?

Oct 26 '19 08:10 friedelwolff

@friedelwolff If this PR is ok and gets merged, then we would be able to merge PR https://github.com/translate/translate/pull/3596 in Translate Toolkit to get rid of this deprecated function.

Oct 26 '19 09:10 unho

@friedelwolff Also check PR #3272 which kinda does the same thing as this one.

Oct 26 '19 09:10 unho

The two functions are not equivalent:

>>> from translate.storage import pypo
>>> pypo.extractpoline('"abc"')
'abc'
>>> pypo.unescape('"abc"')
'"abc"'

What am I missing?

Oct 26 '19 14:10 friedelwolff

You are right, they are not the same.

Oct 26 '19 19:10 unho