react-static-tweets icon indicating copy to clipboard operation
react-static-tweets copied to clipboard

Better style encapsulation

Open DaniGuardiola opened this issue 4 years ago • 4 comments

Done:

  • Added CSS reset (all: initial) to .static-tweet and all children (should fix #13).

Untested, pls help me out @transitive-bullshit, check your DMs :)

Other ideas:

  • [ ] Make parent class more specific, for example: static-tweet => __static_tweet__
  • [ ] Change selectors to depend on the parent class, for example: .static-tweet-anchor => .static-tweet .anchor
  • [ ] CSS modules? (I don't really think it adds much value but it's an option)

DaniGuardiola avatar Mar 31 '21 09:03 DaniGuardiola

Someone is attempting to deploy a commit to a Personal Account owned by @transitive-bullshit on Vercel.

@transitive-bullshit first needs to authorize it.

vercel[bot] avatar Mar 31 '21 09:03 vercel[bot]

@DaniGuardiola I didn't now about the all: initial trick — this is awesome.

I honestly think it's good enough assuming it works. Let's keep it simple for now.

Let me know when you think it's good to merge.

Thanks!

transitive-bullshit avatar Mar 31 '21 23:03 transitive-bullshit

I will take another look at this after we find a fix for #23 which is currently blocking react-static-tweets from being used with webpack 5.

transitive-bullshit avatar Apr 07 '21 02:04 transitive-bullshit

@transitive-bullshit see https://github.com/transitive-bullshit/react-static-tweets/issues/23#issuecomment-814783953

DaniGuardiola avatar Apr 07 '21 10:04 DaniGuardiola