nextjs-notion-starter-kit icon indicating copy to clipboard operation
nextjs-notion-starter-kit copied to clipboard

Enhancement: Discord Added for Social links and footer and use react-icons instead

Open nijamaDev opened this issue 2 years ago • 6 comments

Made a simple change so the icons in the social links use react-icons instead of having the pure svg defined in the file, also changed the icons import in the footer to have cleaner and more consistent code.

List of changes:

  • Replaced '@react-icons/all-files' with updated 'react-icons'
  • Cleaner imports for icons
  • Use react-icons components instead of pure svg for the social links
  • Added Discord to the social links and footer
  • Better comments in site.config.ts

nijamaDev avatar Dec 19 '22 04:12 nijamaDev

@nijamaDev is attempting to deploy a commit to the Saasify Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 19 '22 04:12 vercel[bot]

this code is full of garbage bloat & security concerns.

Restricting EsLint from proper checks Intentionally setting a security policy restricting script sources checking for runtime env in gitactions...

I could go on here, but I don't have to.

transitive -bullshit is right. shame on you all

GitMac32 avatar Mar 24 '23 14:03 GitMac32

this code is full of garbage bloat & security concerns.

Restricting EsLint from proper checks Intentionally setting a security policy restricting script sources checking for runtime env in gitactions...

I could go on here, but I don't have to.

transitive -bullshit is right. shame on you all

Excuse me? What are you talking about?

I think you might be in the wrong PR. I just added a way of setting up discord to the social links and on the footer and updated the react icons

nijamaDev avatar Mar 25 '23 02:03 nijamaDev

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar Jul 14 '23 04:07 socket-security[bot]

Thanks @nijamaDev. This PR looks great. Sorry I don't have time to maintain this project properly and I really have no idea what the other user was talking about.

I'm going through and doing a bunch of updates at the moment, so will consider these changes in a bit.

transitive-bullshit avatar Dec 17 '23 05:12 transitive-bullshit

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 49.4 MB kamijin_fanta

🚮 Removed packages: npm/@react-icons/[email protected]

View full report↗︎

socket-security[bot] avatar Aug 05 '24 15:08 socket-security[bot]