nextjs-notion-starter-kit
nextjs-notion-starter-kit copied to clipboard
transitive-bullshit
feat: make the bg color more 'notion'
The bg style of notion-text is not correct, exist some duplicate colors, example notion link: https://www.notion.so/northisle/Text-Bg-Color-e85150a465f34a45b60ac4bc667ab869
| before | after |
|---|---|
 |
 |
Someone is attempting to deploy a commit to a Personal Account owned by @transitive-bullshit on Vercel.
@transitive-bullshit first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @iNorthIsle thanks for the PR 👋
I think I have the same feedback here as my comment on https://github.com/transitive-bullshit/nextjs-notion-starter-kit/pull/253#issuecomment-1089522007. tbh I'm not sure how to proceed since these colors weren't meant to match notion's.
Suggestions welcome.
Matching Notion's colors would be the expected default. Maybe a way to easily override them from config could help, or simply point out where to change them in the code, using css variables might help as well with a dedicated theme.css file or something similar.
I'm not sure how difficult it is to use Site config variable within CSS with the current setup.
Matching Notion's colors would be the expected default. Maybe a way to easily override them from config could help, or simply point out where to change them in the code, using css variables might help as well with a dedicated theme.css file or something similar.
I'm not sure how difficult it is to use Site config variable within CSS with the current setup.
I agree with U, Matching notion's default colors will be less confusing, and it also can be overridden by the site.config.js.