conflux icon indicating copy to clipboard operation
conflux copied to clipboard

Published 20 hours ago • verified publisher icon transcend-io

Abort handling

Open bencmbrook opened this issue 4 years ago • 4 comments

This bug wasn't caught by tests.

This PR is currently in the test-writing stage, not bugfix. Closes #56

bencmbrook avatar Sep 25 '20 08:09 bencmbrook

https://developer.mozilla.org/en-US/docs/Web/API/AbortController

Haven't used this before. Looks good though. Does this change the implementation (given our class extends TransformStream) or just recommended API?

bencmbrook avatar Sep 25 '20 16:09 bencmbrook

This will change our implementation and also add an additional API surface to for API consumers to input an AbortController (probably during conflux.Writer instantiation).

eligrey avatar Sep 25 '20 20:09 eligrey

@eligrey given https://github.com/transcend-io/penumbra/pull/148 are there any changes required to Conflux for abort handling?

bencmbrook avatar Sep 30 '20 23:09 bencmbrook

It doesn't seem like it's actually necessary to expose an explicit AbortController in Conflux with Penumbra's wrapper.

eligrey avatar Sep 30 '20 23:09 eligrey