conflux icon indicating copy to clipboard operation
conflux copied to clipboard

Published 20 hours ago • verified publisher icon transcend-io

Canceling/aborting streams

Open vincaslt opened this issue 4 years ago • 3 comments

Currently the transform stream reads the file streams in a loop while(true), and pipes the data to the transform stream controller as an output. There are two issues:

  1. If a file stream was aborted the error is thrown, but the transform stream doesn't get canceled.
  2. If the transform stream stream writer gets aborted, the cancelation does not get piped through to another stream.

vincaslt avatar May 08 '20 11:05 vincaslt

Hey @vincaslt do you have a test case for this? Started crafting some here https://github.com/transcend-io/conflux/pull/82

bencmbrook avatar Sep 25 '20 08:09 bencmbrook

I think we should improve support for AbortController to better fix this. @bencmbrook I'll have a look at this & review your PR today

eligrey avatar Sep 25 '20 16:09 eligrey

Would really like to have this. I upload zip files to and when the request files there is no way to signal to the zip transformer to stop. It just throws an error somewhere where I can't catch it.

rowanG077 avatar Jun 23 '21 14:06 rowanG077