Simeon Andreev

> One thing I believe is important is that if user closes the popup (hits Escape), the popup doesn't show again except if it has actual proposals. To be clear,...

> If JUnit 6 can run all of JUnit 5 we might not need JUnit 5 anymore. Much like JUnit 4 is used to support JUnit 3 . I've opened...

I'm trying to build locally with the required PDE changes to test them, but I run into issues: ``` clear ; git clean -fdx ; git submodule foreach "git clean...

> Are you sure you want to `rm -rf /tmp/.m2/ ` your m2 repo + the settings? That's a bit unusual and you likley then need to specify an explicit...

I did grep what platform/Eclipse/Xtext repositories I have, the extension in question is barely used. I only find mentions in the platform UI repository. ``` In directory: eclipse.platform.ui/ bundles/org.eclipse.ui.ide/schema/markerSupport.exsd: bundles/org.eclipse.ui.ide/schema/markerSupport.exsd:...

@travkin79 feel free to do code clean-ups after we've merged the PR, I've adjusted it to make the review as easy as possible.

OK, last remaining item: @travkin79 , you mention groups in the original commit message. I didn't notice a change in the group code though (aside from removing the caching). Can...

> > @travkin79 feel free to do code clean-ups after we've merged the PR, I've adjusted it to make the review as easy as possible. > > I guess, you...

> There's another thing left open: We have to decide whether to change the default of making new marker fields invisible by default. I think, we can safely do that...

Will merge the PR tomorrow. Let me know if there is any feedback that has not been addressed.