UI is very hard to read when using light themes

[arirei]

Environment & Versions

• System: Endeavour OS, Arch-based
• Termusic version: v0.12.0[c] from arch repos

Description of the Problem

Some UI elements are very hard to read when using light themes in a terminal. Screenshot attached.

[hasezoey]

For testing, what theme is that?

[arirei]

Right, sorry for the delay, it's rose piné dawn in wezterm,

here's my config snippet with the color scheme:

local custom = {
	colors = {
		dawn = {
			base = "#faf4ed",
			text = "#575279",
			love = "#b4637a",
			gold = "#ea9d34",
			rose = "#d7827e",
			pine = "#286983",
			foam = "#56949f",
			iris = "#907aa9",
		}
	},
}

[hasezoey]

Thanks for the response, but i dont know how those colors would apply, i am only aware of ANSI color names. Is this the theme you are using, or do you have it customized?

[arirei]

The palette is the same, yes! Sorry about the confusion

[hasezoey]

I forgot to ask more explicitly earlier and just remembered, what is the termusic theme set to? If you cant tell due to the colors, it is also listed in the config (tui.toml). Also if it is anything other than Native, could you try the native theme (via the theme selector)?

[arirei]

Right, it was set to Termusic Default. Native is much better. Maybe it should be the default?

[tramhao]

We should do this, as it'll support pywal theme update as well.

[hasezoey]

Right, it was set to Termusic Default. Native is much better. Maybe it should be the default?

Thanks for the feedback. The problem with the default Termusic Default theme is that is uses a bunch of Color::Reset for background colors, which practically requires the terminal's theme to be compatible, which it was not in this case.

@tramhao While we are at changing the default to the Native Theme, should be remove the Termusic Default theme (a rename would be required anyway), or could you update it so that it does not use Color::Reset? (i am not too great with color matching / selection)

[hasezoey]

While investigating #624 for #631 compatibility, i found that the following issues have come up in addition to the already fixed sections:

• Config editor "inactive" borders dont have a foreground colors set, defaulting to "Reset"
  • due to that, Inputs seemingly fallback to the Paragraph's style's foreground color
• Config editor title colors are not consistent: Key pages use foreground color, whereas non-key pages use the border's color
• On Theme change, the music library does not reload anymore (likely because i removed remounting and forgot this case)

I am not quite sure what to do about the title colors, but i have some proposals: Use Border Color (easiest and most common currently:

Use Foreground color for title text (would require we either vendor all components, or try to change tuirealm upstream, https://github.com/veeso/tui-realm-stdlib/issues/45):

Use Highlight Color for title text (would also require we either vendor all components or try to change tuirealm upstream, https://github.com/veeso/tui-realm-stdlib/issues/45):

---

Also what border color and title color should we use for the inactive style? This should likely also require a new style configuration field. I personally would keep inactive border color and title color the same and set it to something like bright_black by default.

My recommendation for all the above would look something like the following, what do you all think? ("Use Highlight Color for title text" + "inactive border color = title color" + "inactive color = bright_black"): And it would look something like the following in a light theme: