Deprecate lower-case 'prometheus_multiproc_dir'

[michaelusner]

The Prometheus Python client has deprecated the lower-case prometheus_multiproc_dir environment variable. This PR brings the check and warning for this condition into parity with https://github.com/prometheus/client_python/blob/9a6e21de144e81ac666828aa843efb398d184b27/prometheus_client/multiprocess.py#L28

[michaelusner]

Nice - glad to help. Thank you!

On Tue, May 24, 2022 at 2:00 PM Matt Parrett @.***> wrote:

@.**** approved this pull request.

Thanks for this! I was about to write the same PR but thankfully found yours.

The changes look good to me. This fixes #89 https://github.com/trallnag/prometheus-fastapi-instrumentator/issues/89 and #50 https://github.com/trallnag/prometheus-fastapi-instrumentator/issues/50.

Our team ran into a metrics scraping problem like in #50 https://github.com/trallnag/prometheus-fastapi-instrumentator/issues/50 where multiprocess mode was not enabled due to prometheus-fastapi-instrumentator not finding for PROMETHEUS_MULTIPROC_DIR (uppercase). It took a non-trivial amount of time to get to the root cause.

— Reply to this email directly, view it on GitHub https://github.com/trallnag/prometheus-fastapi-instrumentator/pull/42#pullrequestreview-983718873, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ5DF4HNLRXWSYUQN7ZZ63VLUROTANCNFSM46MFMLZA . You are receiving this because you authored the thread.Message ID: <trallnag/prometheus-fastapi-instrumentator/pull/42/review/983718873@ github.com>

[tomtom103]

+1 For this, caused our team some major headaches...

[michaelusner]

@mattmp-mercari Is there anything else I need to do to get some eyes on this PR? It's been in limbo for more than a year now. Please let me know if there's anything I need to do from my end. Thanks!

[trallnag]

Closing because I have merged this in #217. Failed to push the rebase to this branch / PR.

[trallnag]

Thank you, @michaelusner