prometheus-fastapi-instrumentator
prometheus-fastapi-instrumentator copied to clipboard
Remove print statement from middleware
As mentioned in issue #156 and #151 the middleware prints at sometime. I simply removed the print statement.
π
Thanks for this one :)
Anyone who can merge this? Having this print statement is really really annoying.
cc: @trallnag @mander1000
β on this one... have been hunting this down today.
this was a source of insanity for us! and i'm very happy i found this, but am disappointed that it has not yet been fixed.
@trallnag @mander1000 Can we merge this please?
Hello?! @trallnag
In the meantime, my Splunk is going
True
True
True
β¦
Oh, wow you have True, mine is always False. Lucky you ;)
Oh, wow you have True, mine is always False. Lucky you ;)
That extra letter is going to cost you π
At least @trallnag moved some files this weekend... hopefully picking this one up soon as well.
Codecov Report
Merging #157 (e1669c8) into master (8f72053) will decrease coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 93.51% 93.48% -0.03%
==========================================
Files 4 4
Lines 262 261 -1
==========================================
- Hits 245 244 -1
Misses 17 17
Impacted Files | Coverage Ξ | |
---|---|---|
...rc/prometheus_fastapi_instrumentator/middleware.py | 88.75% <ΓΈ> (-0.14%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
πΎ for everyone! Thanks!
Thanks for giving a reason to celebrate today π
Cheers πΎ