prometheus-fastapi-instrumentator icon indicating copy to clipboard operation
prometheus-fastapi-instrumentator copied to clipboard

Remove print statement from middleware

Open nikstuckenbrock opened this issue 2 years ago β€’ 5 comments

As mentioned in issue #156 and #151 the middleware prints at sometime. I simply removed the print statement.

nikstuckenbrock avatar Jun 30 '22 05:06 nikstuckenbrock

πŸ‘

timurstrekalov avatar Jul 06 '22 12:07 timurstrekalov

Thanks for this one :)

letmerecall avatar Jul 08 '22 08:07 letmerecall

Anyone who can merge this? Having this print statement is really really annoying.

cc: @trallnag @mander1000

letmerecall avatar Jul 29 '22 08:07 letmerecall

βž• on this one... have been hunting this down today.

kitofr avatar Aug 08 '22 15:08 kitofr

this was a source of insanity for us! and i'm very happy i found this, but am disappointed that it has not yet been fixed.

BrettMoan avatar Aug 08 '22 20:08 BrettMoan

@trallnag @mander1000 Can we merge this please?

majedtaki avatar Aug 12 '22 19:08 majedtaki

Hello?! @trallnag

haf avatar Aug 19 '22 13:08 haf

In the meantime, my Splunk is going True True True …

timurstrekalov avatar Aug 19 '22 13:08 timurstrekalov

Oh, wow you have True, mine is always False. Lucky you ;)

haf avatar Aug 19 '22 13:08 haf

Oh, wow you have True, mine is always False. Lucky you ;)

That extra letter is going to cost you πŸ˜†

timurstrekalov avatar Aug 19 '22 13:08 timurstrekalov

At least @trallnag moved some files this weekend... hopefully picking this one up soon as well.

kitofr avatar Aug 22 '22 06:08 kitofr

Codecov Report

Merging #157 (e1669c8) into master (8f72053) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   93.51%   93.48%   -0.03%     
==========================================
  Files           4        4              
  Lines         262      261       -1     
==========================================
- Hits          245      244       -1     
  Misses         17       17              
Impacted Files Coverage Ξ”
...rc/prometheus_fastapi_instrumentator/middleware.py 88.75% <ΓΈ> (-0.14%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 22 '22 12:08 codecov[bot]

🍾 for everyone! Thanks!

timurstrekalov avatar Aug 22 '22 16:08 timurstrekalov

Thanks for giving a reason to celebrate today πŸ˜‰

letmerecall avatar Aug 22 '22 16:08 letmerecall

Cheers 🍾

kitofr avatar Aug 30 '22 13:08 kitofr