algo icon indicating copy to clipboard operation
algo copied to clipboard

feat: add support for vultr api v2

Open dhruvkelawala opened this issue 1 year ago • 9 comments

Description

Added support for Vultr Api v2 as new accounts on Vultr won't be able to use v1 api. Old accounts will be unable to use v1 api after June 2023.

Motivation and Context

This change makes sure AlgoVPN can be use by new and old users of Vultr

Fixes #14580

How Has This Been Tested?

Tested by Creating a VPS on Vultr with Ubuntu on my macbook m1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ ] I have read the CONTRIBUTING document.
  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

dhruvkelawala avatar Mar 04 '23 03:03 dhruvkelawala

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 04 '23 03:03 CLAassistant

👍 Worked well for me, thanks

cooper667 avatar Apr 06 '23 06:04 cooper667

Waiting for it to be merged. Not sure if it will ever be 😂

dhruvkelawala avatar Apr 07 '23 11:04 dhruvkelawala

Thanks for the review! Please feel free to merge 🙂

dhruvkelawala avatar May 16 '23 18:05 dhruvkelawala

@pentest01 @mkurapov Any plans to merge this and make a release?

dhruvkelawala avatar May 26 '23 11:05 dhruvkelawala

Hi, would love to see this released.

amitai avatar Nov 18 '23 12:11 amitai

I tried with this fork and still got the API error:

TASK [cloud-vultr : Creating a firewall group] *********************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Reached API retries limit 5 for URL https://api.vultr.com/v1/firewall/group_list, method GET with data None. Returned 503, with body: HTTP Error 503: API v1 Gone b'Sorry, all newly created accounts are forbidden from using API v1, all other accounts are able to use this deprecated API until September 30, 2023 at which point Vultr API v1 will be sunset. Please use API v2.'", "vultr_api": {"api_account": "default", "api_endpoint": "https://api.vultr.com", "api_retries": 5, "api_retry_max_delay": 12, "api_timeout": 60}, "vultr_firewall_group": {}}

amitai avatar Nov 28 '23 17:11 amitai

Sorry for my delay. Feel free to rebase and I'll review

jackivanov avatar Dec 07 '23 23:12 jackivanov

Will do it

dhruvkelawala avatar Dec 09 '23 19:12 dhruvkelawala