roar icon indicating copy to clipboard operation
roar copied to clipboard

loosen version requirement on representable

Open and0x000 opened this issue 3 years ago • 4 comments

with the previous restriction, upgrading to representable 3.1.0 caused roar to be downgraded to 0.12.7.

There was no other combination of compatible versions.

~ # cat Gemfile
# frozen_string_literal: true

source 'https://rubygems.org'

gem 'representable', '~>3.1.0'
gem 'roar', '~>1.1.0'

~ # bundle install 
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Bundler could not find compatible versions for gem "representable":
  In Gemfile:
    representable (~> 3.1.0)

    roar (~> 1.1.0) was resolved to 1.1.0, which depends on
      representable (~> 3.0.0)

and0x000 avatar Apr 12 '21 13:04 and0x000

tests require a version of representable with the fixes in https://github.com/trailblazer/representable/pull/249 to be released.

and0x000 avatar Apr 12 '21 14:04 and0x000

@and0x000 Thanks for the PR!

@seuros About the representable error, isn't this a use case for virtus_coercion module ?

yogeshjain999 avatar Apr 13 '21 05:04 yogeshjain999

@yogeshjain999 dry-types is not part of the bundle

Virtus and dry-type are both optional

seuros avatar Apr 13 '21 05:04 seuros

@seuros Agree. But Roar::Coercion module uses virtus and I remember there was a PR to create a separate module for it in representable.

Should we do the similar separation here too ?

yogeshjain999 avatar Apr 13 '21 05:04 yogeshjain999