reform icon indicating copy to clipboard operation
reform copied to clipboard

Expose raw validation results

Open dnd opened this issue 6 years ago • 2 comments

As per @apotonick's request in #410 here is a PR to start the conversation about changes to Reform.

A couple things I noticed as I went through this.

  • #failure? did not actually return a boolean value. It just returned whatever was in @failure. Since a new #failure method was being added, I updated #failure? to be more consistent with the expectation of a ? method.
  • Is the result.rb line 9 is correct behavior? Should it instead be a map? As it is now, it's just going to find the first failure of the combined lists. Couldn't there be multiple?

dnd avatar Aug 17 '18 01:08 dnd

@apotonick I don't think these failures are the fault of anything I did, are they?

dnd avatar Aug 20 '18 19:08 dnd

@fran-worley @apotonick should we consider these changes for the next release - if yes, let’s add it in the 2.3v milestone

emaglio avatar Jul 12 '19 09:07 emaglio