reform-rails

reform-rails copied to clipboard

Acceptance validation does not work on Rails 7

2

Run tests against `RAILS_VERSION=7.0.0` `validates :accept, acceptance: true` stops work correctly and fails

rzepetor

`Reform::Rails` doesn't work with Rails 6.1 well

7

When using `Reform::Rails` with Rails 6.1, error messages of form can't acquire. This is because `Reform::Contract::Result` expected that error messages are `Hash` or `Array`. https://github.com/trailblazer/reform/blob/bcae40b7405a9ac3ee46507fa2c85acbc997a8c0/lib/reform/result.rb#L37 But in Rails 6.1, error...

y-yagi

fix infinite loop by parent attr

4

kmsheng

calling form.validate throws error stack level too deep

4

This error occurs when using collection and Disposable::Twin::Parent together For example ```rb require "reform" require "reform/rails" require "disposable" require "disposable/twin/parent" class SampleForm < Reform::Form feature Disposable::Twin::Parent property :name validates :name,...

kmsheng

validates: { ... } duplicate error messages

3

In my form I have such property and its validations declaration: ```ruby properties :group, :manager, validates: { presence: true, length: 1..12 } ``` ```ruby property :warehouse, validates: { presence: true,...

AurimasLazdauskas

New error objects in rails 6.1

10

### Complete Description of Issue Hi, I'm trying to upgrade my reform 2.3 app to rails 6.1 and seeing a few issues. I found https://github.com/trailblazer/reform-rails/issues/86 but did not see any...

cherbst-2112

respond_to? method only takes one parameter

3

``` /work/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/super_diff-0.8.0/lib/super_diff/object_inspection/inspection_tree_builders/default_object.rb:46: warning: Reform::Form::ActiveModel::Validations::Result::ResultErrors#respond_to?(:to_hash) uses the deprecated method signature, which takes one parameter /work/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/reform-rails-0.2.2/lib/reform/form/active_model/validations.rb:165: warning: respond_to? is defined here ``` It should take an optional second argument `include_all`: https://ruby-doc.org/core-3.0.2/Object.html#method-i-respond_to-3F

jcoyne

Check the form for any errors

6

I'm working on migrating from reform 2.2.4 to 2.3.3 and from reform-rails 0.1.7 to 0.2.1. In some places we have a code like this: ```ruby form = UserForm.new(user) form.tap do...

TarasBardiuk

property :model broke form_for support, because of name conflicts

4

form_object.model should return associated model. But if form_object have declared property with name "model" it cause name conflicts ``` ruby class CarForm < Reform::Form property :vin property :year property :make...

SanderMander

Add support for custom error messages for using in form objects. In the current gem state, key `message` in options is ignored: ``` property :email validates :email, unique: { message:...

dmitrylomako-mobidev