cells-rails icon indicating copy to clipboard operation
cells-rails copied to clipboard

Generator does not match trailblazer concept conventions

Open pmackay opened this issue 8 years ago • 3 comments

The TRB 2.0 file layout suggests a file for each cell view mode and the templates go in /view. The current generator creates a cell.rb and a /views directory. Should the cell-rails generator be updated to match the TRB conventions?

pmackay avatar Aug 11 '17 16:08 pmackay

Thanks Paul, I believe the generator now sits in https://github.com/trailblazer/trailblazer-generator !

apotonick avatar Aug 11 '17 16:08 apotonick

Thanks for reply @apotonick, could you expand a bit on this? Are you suggesting that any generator functionality in this gem should be moved to trailblazer-generator? trailblazer-generator seems to be in WIP state, so is the dev focus on improving that rather than updating any generator functionality here? Ultimately should the generator code from this gem be removed?

thanks!

pmackay avatar Aug 14 '17 10:08 pmackay

Ultimately, we want to drop Cells ViewModel and Concept and only support Trailblazer::Cell - which means that... we somehow would've to merge/reference... uhm....

apotonick avatar Aug 14 '17 12:08 apotonick