leaflet.extras2 icon indicating copy to clipboard operation
leaflet.extras2 copied to clipboard

addWMS() does not hide the attribution when corresponding group is hidden

Open florisvdh opened this issue 1 year ago • 2 comments

After adding a WMS layer with addWMS(), the attribution display at the bottom is not toggled when the group is shown or hidden respectively. This contrasts with such toggle-behaviour in leaflet::addWMSTiles(), where the attribution is hidden if the group is hidden.

The attached zipped html notebook – leaflet_issue_notebook.nb.html.zip – compares this behaviour between leaflet (first map) and leaflet.extras2 (second map).

I believe leaflet.extras2 should follow the behaviour of leaflet for this.

florisvdh avatar Feb 27 '23 10:02 florisvdh

You're right, but I do think the bug comes from the underlying plugin library. I will have a deeper look into it, or you could open an Issue here https://github.com/heigeo/leaflet.wms

trafficonese avatar Feb 28 '23 07:02 trafficonese

https://github.com/heigeo/leaflet.wms/issues/76

trafficonese avatar Apr 20 '23 11:04 trafficonese