fix: ensure proper logs for aborted streaming responses
What does this PR do?
This PR ensures that logs for streaming connections aborted from clients contain updated request data.
Motivation
Closes #10807
More
- [ ] Added/updated tests
- [ ] Added/updated documentation
Additional Notes
N.A.
Hello @hood,
Sorry for the late reply.
Looking at the changes, I can see that the necessary adjustments to add tests are still in progress. I see that you have implemented what looks like to be an aborted stream response. This approach looks, at a glance, complicated, are you still iterating on it? I'm wondering if we should just test the abort, and show that no matter what was done before the abort of the request, the access log is filled with correct values. Am I missing something, and that was what you have started to implement in the tests?
As a side node, could you please also rebase the changes on the master branch (we updated it recently). Thanks!
Hello @hood,
Do you mind if we rebase the changes and push review commits?
Hey, @rtribotte Sorry for not answering, somehow I lost track of the notifications for this PR.
Great to know the fix got merged. 👍