traefik icon indicating copy to clipboard operation
traefik copied to clipboard

chore(webui): Migrate to Quasar 2.x and Vue.js 3.x

Open andsarr opened this issue 1 year ago • 6 comments

What does this PR do?

Vue.js 2.x has reached EOL and it should not be used anymore. This PR migrates the Web UI to Quasar Framework 2.x and Vue.js 3.x.

Motivation

Fixes #9932

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

Additional Notes

andsarr avatar Feb 07 '24 20:02 andsarr

@mmatur the current changes have migrated the WebUI from Vue.js v2.x to 3.x, from Quasar 1.x to v2.x and from Webpack to Vite.

Should I stop at this point or should I also migrate from Vuex to Pinia?

andsarr avatar Feb 10 '24 13:02 andsarr

@andsarr, to me you can stop it.

Thanks for your job on it.

mmatur avatar Feb 12 '24 10:02 mmatur

The color difference is fixed as well as the chart difference.

There is one problem that I haven't been able to fixed and that kind of happens randomly. When navigating to the to the Service Details Page or the Middleware Details Page, an exception is thrown:

Screenshot_20240213_230859

This is because the on-load-more property is not define for the MainTable used in those components. But I get the exception even after setting a default value to the property or defining it explicitly. I get the exception also even after testing if the variable is undefined in an if statement. I have no idea why!!.

andsarr avatar Feb 13 '24 21:02 andsarr

The error in the MainTable component is fixed. @mmatur, @rtribotte should I do something else to get this merged?

andsarr avatar Feb 22 '24 19:02 andsarr

By the way, after the review, it is probably good to squash the commits before merging.

andsarr avatar Feb 22 '24 19:02 andsarr

You don't need to squash, our merge-bot always rebases the PR and squashes the commits.

ldez avatar Feb 22 '24 22:02 ldez

Thanks @gndz07

andsarr avatar Feb 24 '24 12:02 andsarr

Hey @andsarr,

Thank you for the contribution 🎉

nmengin avatar Feb 26 '24 13:02 nmengin