traefik-helm-chart icon indicating copy to clipboard operation
traefik-helm-chart copied to clipboard

Ingressclass template assumes semver-compatible image tag

Open remotezygote opened this issue 3 years ago • 2 comments

I am trying to use a custom image with the chart via garden, but since garden tags its output images with the module version, and that is not semver-compatible, the following line causes an error when building the helm module:

https://github.com/traefik/traefik-helm-chart/blob/27ed59cc612f1140cd6e03fdef6fcac6d973e526/traefik/templates/ingressclass.yaml#L1

Error:

Error: template: traefik/templates/ingressclass.yaml:1:41: executing "traefik/templates/ingressclass.yaml" at <semverCompare ">=2.3.0" (default 
.Chart.AppVersion .Values.image.tag)>: error calling semverCompare: Invalid Semantic Version

remotezygote avatar Jun 23 '21 23:06 remotezygote

Hi,

This is supposed to check for the Traefik image/version IngressClasses support. Could you give us a sample of the image tag that would be used in your case? Any way we could use a regular expression, extracting Traefik real version out of it? Otherwise, I guess we could make the argument that creating an IngressClass which is not strictly necessary, when unable to guess the image version, would not break anything...

faust64 avatar Jul 04 '21 13:07 faust64

I'm running into the same thing when I specify the SHA of an image, e.g.:

  image:
    name: 12345678910.dkr.ecr.eu-west-1.amazonaws.com/traefik
    tag: 2.4.8@sha256:12345678910abcdefg

seeing as .Values.ingressClass.enabled defaults to false, is it reasonably safe to assume that users enabling it would be aware of the version requirement (through documentation perhaps)?

eversC avatar Dec 20 '21 12:12 eversC