traefik-helm-chart
traefik-helm-chart copied to clipboard
enable prometheus metrics collection
- Add arguments to expose prometheus metrics endpoint
- Add ingress to map traefik pods
- Add serviceMonitor to select ingress objects
- Add prometheusRules section
Closes: https://github.com/traefik/traefik-helm-chart/issues/156
Signed-off-by: Diogo Guerra [email protected]
I'm running this in dev environment since few days and it seems to work as expected. Helm:
version.BuildInfo{Version:"v3.4.2", GitCommit:"23dd3af5e19a02d4f4baa5b2f242645a1a3af629", GitTreeState:"dirty", GoVersion:"go1.15.5"}
k8s:
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.3", GitCommit:"1e11e4a2108024935ecfcb2912226cedeafd99df", GitTreeState:"clean", BuildDate:"2020-10-14T12:50:19Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.12-eks-7684af", GitCommit:"7684af4ac41370dd109ac13817023cb8063e3d45", GitTreeState:"clean", BuildDate:"2020-10-20T22:57:40Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}
UP
Any news?
Do you need any help to get this merged ?
I really need this too.
So, should i drop .Capabilities.APIVersions.Has "monitoring.coreos.com/v1 then?
@dioguerra please do.
Hello @dioguerra,
We can consider merge this PR, but it will need a bit of work.
Would you rebase it and takes into account that, there are now some options to enable prometheus metrics ?
Did a quick fix. Still need to retest it. Is this something that looks acceptable?
I updated the PR, rebased and added some tests. Before we merge it, anything we missed ?
@mloiseleur thanks for making the final push, i could not sorry...