traefik-helm-chart
traefik-helm-chart copied to clipboard
Default values file probably shouldn't have any ports actually defined
It would be really helpful if the ports
section of values.yaml didn't have any actual ports defined.
The major issue is that it's pretty common for people to subchart upstream in order to add customization. I see the logic in having helpful defaults but for values like maps and arrays the values are merged. As the information that is there is very helpful I'd recommend that it just be commented out and have the ports line changed to ports: {}
.
I actually suggested workaround in helm first and was told default values like this are considered bad practice helm/helm/issues/9597#issuecomment-819896909.
I'd be happy to create a PR for this but considering it would change the way the chart works I wanted to get some input from maintainers first.