revisionHistoryLimit cannot be set to 0

[tberreis]

Welcome!

• [x] Yes, I've searched similar issues on GitHub and didn't find any.
• [x] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What version of the Traefik's Helm Chart are you using?

33.2.1

What version of Traefik are you using?

3.2.2

What did you do?

In values.yaml#L26 the revisionHistoryLimit is defined with type:[integer, null];minimum:0.

In deployment.yaml#L41 the conditional if .Values.deployment.revisionHistoryLimit is false, when setting the revisionHistoryLimit to 0. A workaround would be to use "0" (as string) but the schema does not allow a string in that case. Therefore revisionHistoryLimit cannot be set to 0. Another solution could be to remove the if-clause and to define a default instead (e.g. the Kubernetes default of 10).

Relates to helm issue #3164.

What did you see instead?

When setting revisionHistoryLimit to 0, the revisionHistoryLimit is not part of the rendered manifest.

What is your environment & configuration?

  ...
  deployment:
    enabled: true
    kind: Deployment
    revisionHistoryLimit: 0
    ...

[mloiseleur]

Hello @tberreis ,

Thanks for this detailed bugreport. That's right, current code is not allowing this value.

It's possible to adapt the code for this. Feel free to open a PR if you need it.

There are known tricks like the one used on prometheus metrics in order to set the value even if it's 0.