lightweight-charts icon indicating copy to clipboard operation
lightweight-charts copied to clipboard

Update min requirements

Open timocov opened this issue 3 years ago • 3 comments

  • [x] ~Change NodeJS from v12 to v16 (since it's LTS)~ - fixed in #1025
  • [x] ~Change build target from es5 to es2016~ - fixed in #1037
  • [ ] ~Add support for exports map~ - fixed #613

timocov avatar May 21 '21 15:05 timocov

With this you may want to add npm install --legacy-peer-deps, so deprecated packages can be installed in v14+, else people will run into errors:

lightweight-charts>npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/tslint
npm ERR!   dev tslint@"6.1.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer tslint@"^5.0.0" from [email protected]
npm ERR! node_modules/tslint-eslint-rules
npm ERR!   dev tslint-eslint-rules@"~5.4.0" from the root project

h0wXD avatar May 30 '21 23:05 h0wXD

With this you may want to add npm install --legacy-peer-deps, so deprecated packages can be installed in v14+, else people will run into errors:

@h0wXD It looks like support for npm@7, not for nodejs v14 (by default nodejs v14 includes npm@6 which works fine at the moment - Latest LTS Version: 14.17.0 (includes npm 6.14.13) from https://nodejs.org/en/download/).

timocov avatar Jun 01 '21 11:06 timocov

npm ERR! Could not resolve dependency:
npm ERR! peer tslint@"^5.0.0" from [email protected]
npm ERR! node_modules/tslint-eslint-rules
npm ERR!   dev tslint-eslint-rules@"~5.4.0" from the root project

Yeap, problem with dependency in tslint-eslint-rules for tslint Issue about this open from 2020 😢

EugeneMeles avatar Aug 17 '21 11:08 EugeneMeles

@SlicedSilver looks like it is finished already and can be closed?

timocov avatar Feb 07 '23 21:02 timocov

@SlicedSilver looks like it is finished already and can be closed? Thanks :)

SlicedSilver avatar Feb 08 '23 09:02 SlicedSilver