nft-swap-sdk

nft-swap-sdk copied to clipboard

Different information in V4 doc and on GitHub repo: on GitHub is written what is relevant for V3, but not for V4.

1

ErnestMironov

In V3 SDK it's possible to create ERC721 to ERC721 order, while in V4, this possibility is absent.

ErnestMironov

Do we understand correctly that it creates an order for a random NFT from the specified collection? We used this method and our transaction called by this method fails with...

ErnestMironov

Isn't described in documentation. Do we understand correctly that it matches orders to buy/sell ERC-721 tokens and conducts a transaction?

ErnestMironov

An error occurs that a user has an insufficient balance of ERC-20 tokens, although the usual buildOrder works.

ErnestMironov

Noticed that Sepolia was missing from SDK, so figured I would add it. Based my changes off of commit b1e709ef3ceac81a9418804b0b432065dfa5b5d5 (feat: adds Base and Base Goerli Testnet to NFT Swap...

pale-aura

By default order expiry is set to 30 days. While building an order, I've tried to add an expiry field that is set to 24hrs (in milliseconds). I see this...

Azraellx

Bypass MetaMask "At Risk" notices

1

Does anyone know if it's possible to bypass MetaMasks newer "At Risk" notices when approving NFTs as it uses `setApprovalForAll`?

jinsley8

Ports the changes made in V4 for custom ERC20 approval amounts into the V3 SDK. V4 changes referenced https://github.com/trader-xyz/nft-swap-sdk/pull/103 Tested this within my own project and its working as expected.

wizardlabsxyz

[v0.32.0] loadApprovalStatusForOrder still forcing user to choose custom spending cap

2

I just upgraded to `v0.32.0` and read the release notes. I thought it was supposed to now set the minimal viable approval now but I still get MetaMask asking to...

tyh-dev