nft-swap-sdk icon indicating copy to clipboard operation
nft-swap-sdk copied to clipboard

Published 20 hours ago • verified publisher icon trader-xyz

BuildOrderAdditionalConfig in V3 is not documented

Open rico-bee opened this issue 3 years ago • 3 comments

  1. It seems V4 doesn't support NFT < - > NF swap, so I have to use SwapSDK V3 if I need to do NFT <-> NFT?

  2. For V3, it seems the way to specify the fee components will be passing a BuildOrderAdditionalConfig to buildOrder function. However I cannot see any example / doc about how to use this parameter. can anyone share some experiences with the fee configuration ? any help will be much appreciated. thanks

rico-bee avatar Aug 30 '22 11:08 rico-bee

It seems V4 doesn't support NFT < - > swap, so I have to use SwapSDK V3 if I need to do NFT <->?

which swap do you mean? NFT<>ERC20? or NFT<>Bundle?

johnrjj avatar Aug 30 '22 19:08 johnrjj

NFT <-> NFT. for example: https://docs.swapsdk.xyz/readme-1#example-1-nft-less-than-greater-than-nft-swap

rico-bee avatar Sep 01 '22 06:09 rico-bee

@rico-bee the parameters are here on line 94 - https://github.com/trader-xyz/nft-swap-sdk/blob/8b3c3ebfa868cbbb1beb59f49521b956faed0201/src/sdk/v3/INftSwapV3.ts

Better descriptions of parameters here: https://github.com/0xProject/0x-protocol-specification/blob/master/v3/v3-specification.md#order-message-format

jinsley8 avatar Oct 20 '22 17:10 jinsley8