Damian Mooyman

@dhensby I initially commented on that too, but this is behat not phpunit.

I'm struggling with this right now. If I struggle any more I might need to actually implement this. :)

I've made a basic attempt at this with https://github.com/silverstripe-labs/silverstripe-behat-extension/commit/58f54ae239be123fc245ccf561dd8ab298b587a2 Fortunately FF 31 supports error object in window.onerror.

I'd rather move it out of LeftAndMain altogether. What about putting it in FormSchema?

getSchemaRequested is 2 lines; I'm not worried so much if someone has to inline this somewhere.

This logic needs to be shifted out of LeftAndMain, and I would prefer to put it into LeftAndMainFormRequestHandler which is where all form-schema response handling should be done. The forms...

At some point yeah. When I get more time. :)

> The gridfield item count is not required when there is no gridfield title directly above the grid as it causes an unwanted space. What do you mean "not required"?...

I would rather re-arranging the header so that it could fit without it being removed. It's important information that affects information communicated to the content editor; They now need to...

Alternate solution: Before:  After:  ```diff diff --git a/src/Forms/GridField/GridFieldConfig_RecordEditor.php b/src/Forms/GridField/GridFieldConfig_RecordEditor.php index 8e30b3d02..ea24e5238 100644 --- a/src/Forms/GridField/GridFieldConfig_RecordEditor.php +++ b/src/Forms/GridField/GridFieldConfig_RecordEditor.php @@ -29,7 +29,7 @@ class GridFieldConfig_RecordEditor extends GridFieldConfig } $this->addComponent(new GridFieldEditButton()); $this->addComponent(new...