trex icon indicating copy to clipboard operation
trex copied to clipboard

[guardoni] fix guadoni-cli to use the same logic of guardoni-ui about execount, tag, experimentId

Open vecna opened this issue 2 years ago • 4 comments

  • each access to a new profile should have an incremented counter
  • hint: look for the variable newProfile
  • newProfile should be removed because when execount === 1 then is newProfile === true
  • this should be saved in guardoni.json inside of the extension
  • this should happen before the brwoser extension get bootstrapped
  • these information should be read later by the background window and returned as part of settings.

vecna avatar Jul 11 '22 10:07 vecna

  • execount should be part of the API protocol and saved by the events.js
  • execount should be part of the HTTP body in the same way experimentId is sent in every object (in extension sync.ts should handle this)

vecna avatar Aug 01 '22 08:08 vecna

This is not happening, the guardoni electron is not using the same logic as the cli. From the backend debug it say !E (means no experiment) and [untagged] is wrong too, as every contribution from guardoni is tagged.

Below a log from the backnd receiving evidences from the guardoni extension

  routes:events Saved 1 htmls metadataId ["2bc16f1b42c16a04970262b22928fa5cb88c7ea7"] [untagged] !E +1m
  route-handler:debug {"responses":{"experimentChannel3":1,"processEvents2":1},"requests":{"experimentChannel3":1,"processEvents2":1}} +2m
  routes:events Saved 3 leaves metadataId ["ae67990a8c5a1b50ba67aa66ac5127a082c42ec4"] [untagged] experimentId DEFAULT_UNSET +3m
  routes:events Saved 12 leaves metadataId ["7ec941f66baffa1d5b9e74f78593cf159a9c6e8a","d6bfd4cddf187c3141a65a07d8257d82d55d30e7"] [untagged] experimentId DEFAULT_UNSET +9s
  route-handler:debug {"responses":{"experimentChannel3":1,"processEvents2":1},"requests":{"experimentChannel3":1,"processEvents2":1}} +3m
  route-handler:debug {"responses":{"experimentChannel3":1},"requests":{"experimentChannel3":1}} +3m

vecna avatar Aug 12 '22 12:08 vecna

as a confirmation the tag is configured in Guardoni image

vecna avatar Aug 12 '22 12:08 vecna

  routes:events Saved 1 htmls metadataId ["5274aadded3d6f5118deebc033c1dd9ab8a8ffed"] {"tclidx":1} experimentId ed0452693edcc641ca9f5e80db17ccc6d3156174 +4m
  route-handler:debug {"responses":{"fetchDirective":1,"experimentChannel3":1,"processEvents2":1},"requests":{"fetchDirective":1,"experimentChannel3":1,"processEvents2":1}} +1m
  routes:events Saved 1 htmls metadataId ["ab277fcea1a32b64f90724a61714830f0b443ade"] {"tclidx":1} experimentId ed0452693edcc641ca9f5e80db17ccc6d3156174 +8s

above it show how the cli works fine

vecna avatar Aug 12 '22 12:08 vecna