openllmetry icon indicating copy to clipboard operation
openllmetry copied to clipboard

feat(qdrant): Add query_batch_points, query_points and query_points_groups semantic conventions

Open duynguyenhoang opened this issue 4 months ago • 5 comments

First MR to add new qdrant sematic conventions.

  • [x] I have added tests that cover my changes.
  • [x] If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • [x] PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • [x] (If applicable) I have updated the documentation accordingly.

[!IMPORTANT] Add new Qdrant semantic conventions to SpanAttributes and update version to 0.4.13.

  • Semantic Conventions:
    • Add QDRANT_QUERY_POINTS_COLLECTION_NAME, QDRANT_QUERY_POINTS_GROUPS_COLLECTION_NAME, QDRANT_QUERY_BATCH_POINTS_COLLECTION_NAME, and QDRANT_QUERY_BATCH_POINTS_REQUESTS_COUNT to SpanAttributes in __init__.py.
  • Versioning:
    • Update version to 0.4.13 in version.py and pyproject.toml.

This description was created by Ellipsis for 3b6ec7a758b0bf085f67ff1ac79096d626be3c14. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • New Features
    • Added new span attributes for enhanced Qdrant query tracking, including collection names and request counts.
  • Chores
    • Updated package version to 0.4.13.

duynguyenhoang avatar Aug 04 '25 13:08 duynguyenhoang

Walkthrough

Four new Qdrant-related span attribute constants were added to the SpanAttributes class in the semantic conventions package. The package version was incremented from 0.4.12 to 0.4.13 in both the code and configuration files. No other logic or metadata was changed.

Changes

Cohort / File(s) Change Summary
Qdrant Span Attribute Additions
packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/__init__.py
Added four new Qdrant-related span attribute constants to the SpanAttributes class.
Version Bump in Code
packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/version.py
Updated __version__ from "0.4.12" to "0.4.13".
Version Bump in Config
packages/opentelemetry-semantic-conventions-ai/pyproject.toml
Updated the package version from 0.4.12 to 0.4.13.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Four new constants hop in with glee,
Qdrant queries now tracked with ease!
A version bump, a tiny jump,
The code is fresh, the docs all plump.
🐇 With every change, we leap ahead—
Semantic trails for all to tread!

[!NOTE]

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 04 '25 13:08 coderabbitai[bot]

@nirga, qdrant introduced new methods and we are going to instrument them

  • query_batch_points
  • query_points
  • query_points_groups

It makes sense to add new span attributes, instead of reuse the current. These new attributes will be used in https://github.com/traceloop/openllmetry/pull/3228

With current package dependencies, I need to separate the MR into 2.

duynguyenhoang avatar Aug 04 '25 15:08 duynguyenhoang

Hi @nirga, Could you please check the PR? Is there anything else need to be done here?

duynguyenhoang avatar Sep 02 '25 10:09 duynguyenhoang

Sorry @duynguyenhoang - missed that! I'd reuse the same semantic convention. I think that's we also do it in otel

nirga avatar Sep 02 '25 15:09 nirga

Alright, I will update my PR to use current semantic convention. And let's discuss to update semantic convention in another thread @nirga

duynguyenhoang avatar Nov 05 '25 08:11 duynguyenhoang