openllmetry icon indicating copy to clipboard operation
openllmetry copied to clipboard

🐛 Bug Report: pinecone-client package is giving error

Open elinacse opened this issue 9 months ago • 7 comments

Which component is this bug for?

Pinecone Instrumentation

📜 Description

as per openllmetry pinecone-instrumentation the supported pinecone package is pinecone-client but seems it's replaces with pinecone hence giving error when trying to run pinecone with pinecone-client pkg installation .

👟 Reproduction steps

do pip install pinecone-client and try to run the pinecone sample . You will get error at runtime

Error -

Exception: The official Pinecone python package has been renamed from pinecone-client to pinecone. Please remove pinecone-client from your project dependencies and add pinecone instead. See the README at https://github.com/pinecone-io/pinecone-python-client for more information on using the python SDK.

👍 Expected behavior

we should install pinecone instead of pinecone-client and do the same change in openllmetry to support pinecone .

👎 Actual Behavior with Screenshots

python sample runs fine with installed pinecone package <6.0.0

🤖 Python Version

3.11.11

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • [x] I checked and didn't find similar issue

Are you willing to submit PR?

Yes I am willing to submit a PR!

elinacse avatar Mar 06 '25 10:03 elinacse

To resolve the error caused by the package name change from pinecone-client to pinecone in the Pinecone Instrumentation for OpenLLmetry, you need to update the dependencies in the OpenLLmetry repository. Specifically, modify the PineconeInstrumentor class in the __init__.py file to use the new package name pinecone instead of pinecone-client. Update the _instruments tuple as follows:

_instruments = ("pinecone >= 2.2.2, <6",)

Additionally, ensure that the pyproject.toml file in the packages/opentelemetry-instrumentation-pinecone directory is updated to reflect this change. This will ensure that the correct package is referenced for instrumentation dependencies [1][2].

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

dosubot[bot] avatar Mar 06 '25 10:03 dosubot[bot]

Todos:

  1. Uninstall dosubot - it's been annoying for us for way too long.
  2. change the package version like you suggested :)

nirga avatar Mar 08 '25 11:03 nirga

I also am experiencing this, and need a fix in.

TheMellyBee avatar Mar 26 '25 20:03 TheMellyBee

Guys this is embarassing

Francisco-Reveriano avatar Jul 05 '25 05:07 Francisco-Reveriano

Hey all, thanks for reporting. Unfortunately, Pinecone introduced a lot of breaking changes - which means this is much more then just a package name change (as you can see I tried doing that with #2764 and failed miserably). We need to fix the instrumentation in order for this to work. We're prioritizing this fix but would appreciate any help.

nirga avatar Jul 05 '25 15:07 nirga

I will fix that issue, can take it @nirga

ozkanuysal avatar Jul 19 '25 17:07 ozkanuysal

@ozkanuysal are you still looking into it ? any update on the PR https://github.com/traceloop/openllmetry/pull/3152 . Thanks !

elinacse avatar Sep 16 '25 17:09 elinacse

@nirga Could you please look into the PR https://github.com/traceloop/openllmetry/pull/3502 for this issue .

elinacse avatar Dec 08 '25 02:12 elinacse