burn
burn copied to clipboard
Remove annoying cargo warning
Checklist
- [x] Confirmed that
run-checks allscript has been executed. - [x] Made sure the book is up to date with changes in this PR.
Changes
Package level profiles are ignored when workspace is enabled so these lines are useless.
This commit moves the profile to the workspace level but only commented for reference as panic, lto and rpath cannot be overridden
Source: https://doc.rust-lang.org/cargo/reference/profiles.html#overrides
The precedence for which value is used is done in the following order (first match wins):
[profile.dev.package.name] — A named package.
[profile.dev.package."*"] — For any non-workspace member.
[profile.dev.build-override] — Only for build scripts, proc macros, and their dependencies.
[profile.dev] — Settings in Cargo.toml.
Default values built-in to Cargo.
Overrides cannot specify the panic, lto, or rpath settings.
Fixes these annoying warning on each workspace package:
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e335552) 86.04% compared to head (fff4589) 86.04%.
Additional details and impacted files
@@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage 86.04% 86.04%
=======================================
Files 521 521
Lines 58289 58289
=======================================
Hits 50153 50153
Misses 8136 8136
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
They actually do nothing already since they are ignored. @nathanielsimard do we remove they completely ? In the end I don't think that's useful to move them at the root level.
@syl20bnr yeah we could remove them altogether
OK, I removed them completely.