Doesn't work at all for git repos

[rcarmo]

I'm doing some basic testing, and apparently you're not allowing for revision ids with more than 3 characters (actually, just saw that you're using int as a revision type in the database - that won't work at all).

There might be more issues, but I've hit upon that one right away.

Removing the "int" specifier from the revision field in db.py appears to fix that across the board, in the sense that I now get a listing of the comments I made.

They still don't display, though, but I think the reason for that is #14.

[livedata]

it works for me

[rcarmo]

So which git plugin are you using, then? I've had this blow up on me when two revisions start with the same numerical prefix (92caef and 92b654) because only the '92' makes it thorough.

On MySQL, mind you. If you're using another database, the int field might not be as... Strict.

Hence my only way to make this work being changing the field type in the DB.

On 16/05/2012, at 20:09, [email protected] wrote:

it works for me

---

Reply to this email directly or view it on GitHub: https://github.com/Automattic/trac-code-comments-plugin/issues/13#issuecomment-5749153

[livedata]

I'm using sqlite and trac 0.13dev

[nb]

Agreed, revision should have been a string. We will need to change the database column for that, though. I will get it in 1.2.0.

[lkraav]

Hey all, letting you know I am about to jump on this issue's bandwagon. Just cherry-picked the @Orio91 patches and going to see how it goes. Both git and multiple repos are essential here.

[lkraav]

First of all, I don't think the v3 database migration works for Postgres. I'm hitting:

ProgrammingError: syntax error at or near "PRAGMA" LINE 1: PRAGMA index_list(code_comments) ^