WaveyCapes icon indicating copy to clipboard operation
WaveyCapes copied to clipboard

Compability with EmoteCraft

Open Derim16 opened this issue 11 months ago • 8 comments

Crash occurs when trying to use any emotion from the EmoteCraft plugin. Tried updating mods - nothing helped. crash-2025-02-07_12.24.57-client.txt

Derim16 avatar Feb 07 '25 09:02 Derim16

Looks like PlayerAnimator deleted some parts of the api. Will have to check if/how it can be restored.

tr7zw avatar Feb 07 '25 09:02 tr7zw

emotecraft uses its playeranimator fork since the original one is dying it's located here https://repo.redlance.org/#/public/dev/kosmx/player-anim

dima-dencep avatar Feb 23 '25 12:02 dima-dencep

it just includes some of my pullrequests, like this one https://github.com/KosmX/minecraftPlayerAnimator/pull/138

dima-dencep avatar Feb 23 '25 12:02 dima-dencep

Wait huh, KosmX does player animator and emotecraft, don't they? So why would they be using a non-public fork?

tr7zw avatar Feb 23 '25 16:02 tr7zw

I am emotecraft maintainer, and the fork is not private, it is in my profile, the change that broke your mod is in upstream

dima-dencep avatar Feb 23 '25 16:02 dima-dencep

Ah ok, that explains it. Then I'll look into getting this fixed soon (probably broke multiple mods of mine too).

tr7zw avatar Feb 23 '25 17:02 tr7zw

With this fix, waveycapes and first person model continue to work as should, added method is marked as deprecated for removal

dima-dencep avatar Feb 25 '25 20:02 dima-dencep

Sorry for lagging behind. Kinda busy irl and have other updates sucking up time. I need to finish up some other parts before I can get to this (namely, a new JIJ build setup to share code like this between mods in a better way).

tr7zw avatar Feb 25 '25 20:02 tr7zw