ItemSwapper icon indicating copy to clipboard operation
ItemSwapper copied to clipboard

Request: 1.18.2 backport

Open Martmists-GH opened this issue 2 years ago • 8 comments

Martmists-GH avatar Dec 03 '22 16:12 Martmists-GH

1.18 might get a backport once the mod is in a more finished state. Note: I only maintain the last 2 major versions, so once 1.20 releases, I'll drop main support for 1.18.

tr7zw avatar Dec 03 '22 17:12 tr7zw

i am also interested

OrdinaryCloverOC avatar Dec 23 '22 20:12 OrdinaryCloverOC

hope soon

IF-desu avatar Feb 04 '23 09:02 IF-desu

Not going to happen anytime soon. 1.19 will now eat more time due to the Mojang release changes, and I'll be busy with uni for at least 3 months starting in 2 weeks(never mind that the mod is still far from done, so porting to 1.18 right now is wasted time). Can I ask why people are still running 1.18? 1.19 has been out for 8 months, with 1.20 creeping closer. grafik

tr7zw avatar Feb 04 '23 23:02 tr7zw

@tr7zw can't speak for everyone, but me and my friends are running a 1.18 modded world, which is nearly impossible to upgrade to 1.19 because some of the worldgen mods (we tried). I'm guessing we are not the only ones. I'm curious if you'd be willing to accept a pull request with 1.18 support?

nevkontakte avatar Feb 04 '23 23:02 nevkontakte

But I mean, then you are running an old version, knowing that no(or rather most) new mods will not be released for it(or mod updates). The same applies to 1.17/1.16/1.12/1.8 etc. If I start now playing a 1.19.x modpack, and 1.20 releases, I know that the pack now is only in maintenance mode. On https://tr7zw.github.io/versions/ I have the current support plans.

I'm curious if you'd be willing to accept a pull request with 1.18 support?

I guess first of all, right now: don't. It is a waste of your time. So much is still changing to get the wanted features implemented. Then having to maintain a different version(1.19.2/1.18.2/forge) would just eat time. Once the mod gets closer to 1.0, then I'll use my fork based backports to handle it (see https://github.com/tr7zw/WaveyCapes/tree/1.18.2-fork ), where just the difference between versions has to be maintained. But if files get refactored on a regular, this would also just run into all the merge conflicts(like normal branches).

tr7zw avatar Feb 04 '23 23:02 tr7zw

I mean, sure, I don't expect that most mods will support the old version, but sometimes a really nice mod comes out and you kind of really want to be able to use it, even if not to the point of abandoning the world you have 😉

If you are saying there's too much churn in the code right now — fair enough, I can wait until 1.0. I know that maintaining forks can be a lot of headache.

nevkontakte avatar Feb 04 '23 23:02 nevkontakte

Updated the versions page to better reflect the versions(1.19.3 and 1.19.2 not being the same), which results in 38(nearly twice as much if you take forge into the count) mod versions that I want to support with the current support logic(most recent version and last version, so 1.19.x and 1.18.x right now). That's quite a lot, considering that I also have to work and finish my bachelor's degree 🙃.

tr7zw avatar Feb 04 '23 23:02 tr7zw