ItemSwapper icon indicating copy to clipboard operation
ItemSwapper copied to clipboard

[BUG] <invMove conflicts with itemswapper>

Open surfishs opened this issue 1 year ago • 10 comments

Version information

0.4.0-1.20-farbic

Other relevant installed mods

https://modrinth.com/mod/invmove

Expected Behavior

Press the shortcut key to open the panel

Actual Behavior

After pressing Shortcut, the panel quickly flashes and closes, unless you hold it down, it will display normally after a while.

Reproduction Steps

install invmove,Press the itemswapper shortcut

Render engine

  • [ ] Vanilla
  • [X] Sodium(optionally with Iris)
  • [ ] Optifine
  • [ ] VulkanMod
  • [ ] Canvas
  • [ ] Other

Additional information

https://modrinth.com/mod/invmove

surfishs avatar Jul 04 '23 05:07 surfishs

Unless you have toggle Mode activated, holding down the key is the intended behaviour. The flicker might be caused by the optifine fix, because optifine was broken with overlays that didn't have that behaviour.

tr7zw avatar Jul 04 '23 06:07 tr7zw

除非您激活了切换模式,否则按住该键是预期的行为。闪烁可能是由 optifine 修复引起的,因为 optifine 被不具有该行为的覆盖层破坏。

No, I'm running on fabric, no optifine.

surfishs avatar Jul 04 '23 06:07 surfishs

Yes, but I had to change code so the mod will work with optifine, that has that flicker apparently as a side effect for some people. I don't know what exactly triggers the flicker to be visible.

tr7zw avatar Jul 04 '23 06:07 tr7zw

I've checked to determine that the error is caused by Invmove, which calls something about the backpack panel. I have a bug demo video, but I can't send it to you here.

是的,但我必须更改代码,以便该 mod 可以与 optifine 一起使用,这对某些人来说显然是一个副作用。我不知道到底是什么触发了可见的闪烁。

surfishs avatar Jul 04 '23 06:07 surfishs

https://github.com/tr7zw/ItemSwapper/assets/96485650/6664be02-40b4-4547-ab08-85a06ecab6fa I didn't release the shortcut, it was a mistake that caused the screen to close automatically, but because I was still holding the shortcut, it would eventually open. @tr7zw

surfishs avatar Jul 04 '23 06:07 surfishs

Same here, running Fabric 1.20.1 with Inv Move.

I want to open the Swapp Screen but i just flashes and closes when i press the hotkey.

I also have the newest Sodium / Sodium Extra / Indium / EMF / ETF / ... ( No optifine tho )

xR4YM0ND avatar Aug 25 '23 21:08 xR4YM0ND

Having the same issue. Turning "Allow Walking With UI" off in itemswapper settings causes the item swapper ui to flicker very fast. Disabling invmove in mod settings doesn't fix it but removing invmove from your mods folder and relaunching fixes this issue.

grimid avatar Jan 06 '24 10:01 grimid

Same issue on Minecraft 1.21 with Fabric 0.16.0, but the issue disapperaed when in a multiplayer server.

Zh40Le1ZOOB avatar Jul 14 '24 08:07 Zh40Le1ZOOB

Noteworthy that Mojang removed the flag to mark ui's that still allow you to move(basically what invMove and this mod needs). So now mods have conflicting solutions that potentially overwrite each other. Right now I don't have the time to look into this.

tr7zw avatar Jul 21 '24 18:07 tr7zw

I have the same issue. But what is noteworthy is that in my case the issue is caused through Amecs. That is, the bug only occurs when Amecs, InvMove, and ItemSwapper are present at the same time. And oddly enough, this issue does not occur with too-many-shortcuts, a fork of Amecs.

Uzimattyan avatar Sep 02 '24 15:09 Uzimattyan