FirstPersonModel icon indicating copy to clipboard operation
FirstPersonModel copied to clipboard

Prone X Offset slider

Open wyretm opened this issue 1 year ago • 7 comments

Would be nice to have since should the player size be larger than usual, via Pehkui or anything else, this becomes your view while prone 2024-05-20_14 59 54

Otherwise lovely mod, can't play without it.

wyretm avatar May 20 '24 12:05 wyretm

This mod doesnt touch the camera. So if the model height != the camera height, yeah this will happen. In the past I did add some workaround for Pehkui breaking sneaking in general, possible they changed something again.

tr7zw avatar May 20 '24 13:05 tr7zw

Thanks for the quick response, I understand that this mod doesn't move the camera, what I was suggesting is the ability to adjust X Offset for the prone position, the same way you can for standing and sitting.

wyretm avatar May 20 '24 13:05 wyretm

The x offset is adjusted and has a slider. Pehkui breaks other mods so they don't know the player is actually sneaking, so Pehkui can do their own offset logic, which in return breaks this mod. 1.20.6 has player scaling built in, so mods like Pehkui are hopefully not required anymore, causing this issue. (Tho I'll have to be honest, kinda forgot to test if everything works correctly before releasing the update)

tr7zw avatar May 20 '24 13:05 tr7zw

To clarify as it seems there's a bit of a misunderstanding happening, I'm not talking about sneaking, I'm referring to being prone, as in lying on the ground. In any case I'm not going to bother you further, thank you for your work.

wyretm avatar May 20 '24 13:05 wyretm

Ah, so you mean the "swimming on land"(literally what it is in terms of what Minecraft thinks, there is no "prone" code/logic). That might actually be something to look into. Then I assume swimming is affected the same way(at least when swimming straight, not up/down)?

tr7zw avatar May 20 '24 13:05 tr7zw

Yes, sorry for the confusion, and yes normal swimming is also affected.

wyretm avatar May 20 '24 13:05 wyretm

Ok yea then I need to look it. Tho 1.20.6's native entity scaling will take priority.

tr7zw avatar May 20 '24 13:05 tr7zw