virustotal3 icon indicating copy to clipboard operation
virustotal3 copied to clipboard

Functions should not exit on requests.exceptions.RequestException

Open doug-the-guy opened this issue 3 years ago • 0 comments

I'm using this API from another script and I've been dealing with the following error:

("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))

I tracked it down to the enterprise LiveHunt function I was using which was catching a requests.exceptions.RequestException, printing the exception and then calling exit(1) which left my script hanging. This is the case for every function that wraps an API endpoint.

I recommend instead to just raise the RequestException or wrap it in some custom exception and let the calling code deal with it.

doug-the-guy avatar Sep 03 '21 15:09 doug-the-guy