py-make icon indicating copy to clipboard operation
py-make copied to clipboard

Now replacing comments with harmless dummy comments before processing…

Open smarie opened this issue 5 years ago • 6 comments

… so as to fix bug when they contain reserved expressions. Fixes #8

smarie avatar Jul 24 '19 10:07 smarie

Coverage Status

Coverage increased (+0.06%) to 96.667% when pulling 3fd465beb03eb00eec8471b71a9425ea76a28af5 on smarie:fix_issue_8 into 66c71a75340cdbae326e6f3d66890f1df75ef7dc on tqdm:master.

coveralls avatar Jul 24 '19 10:07 coveralls

Coverage Status

Coverage increased (+0.06%) to 96.667% when pulling 87b397555f453dc94c56276b413d2e7551e1b9d3 on smarie:fix_issue_8 into 66c71a75340cdbae326e6f3d66890f1df75ef7dc on tqdm:master.

coveralls avatar Jul 24 '19 10:07 coveralls

Coverage Status

Coverage increased (+0.06%) to 96.667% when pulling 87b397555f453dc94c56276b413d2e7551e1b9d3 on smarie:fix_issue_8 into 66c71a75340cdbae326e6f3d66890f1df75ef7dc on tqdm:master.

coveralls avatar Jul 24 '19 10:07 coveralls

the problem with this is:

test:
        echo 'hash#es'

casperdcl avatar Aug 23 '19 02:08 casperdcl

Codecov Report

Merging #9 into master will increase coverage by 0.09%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   94.06%   94.16%   +0.09%     
==========================================
  Files           6        6              
  Lines         118      120       +2     
  Branches       25       26       +1     
==========================================
+ Hits          111      113       +2     
  Misses          4        4              
  Partials        3        3

codecov-io avatar Aug 23 '19 02:08 codecov-io

I see. That might be a little trickier to do then, as of now I have no elegant suggestion to cover this case, apart from explicitly taking into account each possible quote character ' and " (simply finding the beginning-end indices of pairs)...

smarie avatar Aug 31 '19 13:08 smarie