Tianqi Chen

Results 637 comments of Tianqi Chen

seems this behavior was platform dependent, and ideally we should not introduce behavior that only works on one platform but not others. It is also hard for other implementations of...

the only main issue about generate approach is that it may not be comprehensive if we in the end link multiple exports together, which is a less frequent usecase as...

@csullivan please fix the lint error

I think main issue is that the user might slice the memory in zero copy mode, but we could update IsAligned to ensure that we always return true for Tensors...

maybe indeed related to #15596 @Lunderberg seems we need to stringify python errors if they are caught by RPC

Chimingin here a bit, i think the overall we would like to gradually move away from relying on e2e tests. in this case, there are usually two parts: - T0:...