Tianqi Chen
Tianqi Chen
Some update after taking a closer look. Actually right now the proposed ABI did break S0 as well. The main reason was due to the fact that DLManagedTensor's deleter field...
Thanks @wjakob ! Indeed this is worth clarifying. As far as I know, GIL is not necessary if the deleter is defined in C API. There can be cases where...
@wjakob I think your interpretation is correct. However, most of the frameworks implement the allocation of the object themselves in C/C++/cython, then expose to python, in which case the deleter...
While non-native byteorder is useful for serialization and less for in-memory exchange. As of now the implicit assumption seems to be that the `data` should always follow the native-byteorder in...
I also prefer (2) as it simpler
Thanks @wjakob! I agree it might be worthwhile to document the choice. There are different arguments around using signed integers vs unsigned integers (search over the web and there are...
bool is encoded as `UInt(bits=1, lanes=1)` type. One thing that is indeed true is that we have not clearly specified how to store the sub-byte types, in this case they...
Thanks @alonre24 On compiler projects like LLVM, `uint(1)` is used to represent the bool type(think it as a register type). That does not preclude us to think of a storage...
What I originally meant was to specify the sub-bit storage layout, which means `uint(1)` maps to the bool and stores as uint8 in DLPack. When the bool was indeed stored...
Thanks everyone for great discussion so far. Trying to summarize the thread. ## A0: `i1` to represent bool We can use `uint(1)` to represent the intend of the data type....