amazon-s3-php-class icon indicating copy to clipboard operation
amazon-s3-php-class copied to clipboard

Avoid requiring PHP's timezone settings to be set

Open binki opened this issue 13 years ago • 2 comments

PHP makes a lot of notice noise when it hits the strtotime() function and the user hasn't set a timezone. This is because there's a chance that the string being parsed is not a UTC-formatted date. I think that since S3 only gives out dates in UTC, PHP is being silly in requiring that a timezone be set. However, there is no utcstrtotime() function provided by PHP which would be happy to parse timezone-independent (i.e., UTC) dates into unix timestamps.

These two commits avoid this issue. The first uses libcurl's own date parsing for handling an HTTP response's Last-Modified header. The second locally uses a UTC DateTimeZone object when parsing dates stored in the XML documents.

binki avatar Dec 23 '11 04:12 binki

Thanks for this. Just got back from holiday so still trying to catch up! Will examine, test and hopefully merge soon.

tpyo avatar Jan 20 '12 01:01 tpyo

Totally agree with that one

iazi avatar Jul 20 '12 09:07 iazi