Thomas Prouvot

Results 318 comments of Thomas Prouvot

The result looks great @toly11 👏 I checked if we could also use the navigation for internal shortcut links `onDataSelect` for `AllDataBoxShortcut` class and it seems to be OK, would...

No I'm talking about those links which can redirect to setups links such as `Deployment Status`

Few remarks concerning the inject.js script, today it is inserted in the page even if the user doesn't interact with the extension. I would prefer to inject only when the...

Hi @toly11 Did you had a chance to see my previous comments ?

> > and add some comment explaining why you created a inject.js file instead of scripting permission (basically to make the extension work with less permissions which can lead to...

> > Last thing, could you remove the debug logs > > Do you think we should also remove the debug when Lightning navigation fails? (addon/inject.js:19) We can keep the...

I'm thinking about one think also, since we have an option to open the links in a new tab, we should mention that enabling this will prevent the lightning navigation...

Hi @toly11, I've addressed the suggested action on how-to file and option page.

> > Hi @toly11, > > I've addressed the suggested action on how-to file and option page. > > Did you create a suggestion, or should I create a new...

Hi @toly11, I could push my file, thank you for authorising the updates. Last thing, I would like to have a setting which allows users to enable / disable this...