Salesforce-Inspector-reloaded icon indicating copy to clipboard operation
Salesforce-Inspector-reloaded copied to clipboard

Release candidate issue#428 fix

Open waliasandeep opened this issue 9 months ago • 2 comments

…d to query name

Describe your changes

Updated the logic in selectSavedEntry function. Added an additional check that makes sure that the ":" character present is because the user added a query label and not because it is part of the query. Also trimming the query being saved so that the new check works without any issues. Tests scenarios checked:

Label Query
Blank SELECT Id FROM Contact WHERE LastModifiedDate = LAST_N_DAYS:10
Last 10 days query SELECT Id FROM Contact WHERE LastModifiedDate = LAST_N_DAYS:10
Blank SELECT Id FROM Account LIMIT 10
Date Literal Query SELECT Name, LastModifiedDate FROM Account WHERE LastModifiedDate > 2016-05-01T00:00:00Z

Issue ticket number and link : #428

Checklist before requesting a review

  • [x] I have read and understand the Contributions section
  • [x] Target branch is releaseCandidate and not master
  • [x] I have performed a self-review of my code
  • [x] I ran the unit tests and my PR does not break any tests
  • [ ] I documented the changes I've made on the CHANGES.md and followed actual conventions
  • [ ] I added a new section on how-to.md (optional)

waliasandeep avatar May 14 '24 14:05 waliasandeep

Hi @waliasandeep , Thanks for this PR !

Did you had a chance to check my comment on the issue mentioning the fix I was thinking of ?

tprouvot avatar May 15 '24 09:05 tprouvot

Hi @tprouvot !

Yes I did, while I do understand the first pointer that you have mentioned and can update this PR as per that. I might require more details regarding the second and third pointer.

waliasandeep avatar May 15 '24 13:05 waliasandeep

@waliasandeep thank you for the PR ! I also fixed the Save Query dropdown menu position

tprouvot avatar May 30 '24 09:05 tprouvot