Tim Pope
Tim Pope
Ngl I hate that `([])` nesting more than `=>`. Do we really need the exit code? One thing I will say is that if we stick with `Success`/`Failure`, the natural...
Still not ready to act on this, but I can assure you I consider this mandatory for the next stable release, as it's impossible to tell if the job adapter...
I think I would be okay with this in the case that there were no specific errors matched, just a capture of all output.
Oh wow, so unescaped pipes in `'makeprg'` "leak out" in to Vimscript? Gross. This particular example can be rewritten to use `if`, so I don't consider this high priority. It's...
Keep an eye out for other oddities. For example, normally anywhere you can use a `|`, you can comment with `"`, but that's not true with `'makeprg'`.
Your use of `grep` suggests what you really want is a proper `'errorformat'` that matches the lines in question.
I don't think I'm on board with the whole `dispatch_temporary_quickfix_height` shenanigans.
Can you be more specific about the right/wrong directories? `'autochdir'` is a nightmare to deal with but I wouldn't expect it to cause a problem here. Putting `cd` in `'makeprg'`...
That's a pretty big feature to yank out from under people. But I'm not sure that's the root cause, as the script we generate begins with a `cd`. You should...
I would add `let s:quickfix_info = has('patch-7.4.2200')` and use that to replace all `exists(':chistory')` conditionals.