doobie-http4s-sangria-graphql-example icon indicating copy to clipboard operation
doobie-http4s-sangria-graphql-example copied to clipboard

Update dependencies, including upgrade to Cats Effect 3

Open mariolyon opened this issue 2 years ago • 3 comments

This PR updates dependencies, including Cats Effect 3 which has many changes from Cats Effect 2. This was my guide: https://typelevel.org/cats-effect/docs/migration-guide.

The PR also include a scalafmt config copied from the typelevel/cats-effect repo, so there are formatting changes.

The logger is also being created wherever it is used, which is the safer and clearer way (https://typelevel.org/log4cats/#examples).

Overall, it's runnable, and it works like the original.

mariolyon avatar Apr 29 '22 11:04 mariolyon

Thanks! Looks like you're still working on this. Let me know when it's ready.

tpolecat avatar Apr 29 '22 16:04 tpolecat

Hi Rob,

thankyou! it's ready now, could you please review it?

I fiddled around with the scalafmt config a lot, to match the original formatting as much as possible.

Mario

On Fri, Apr 29, 2022 at 6:49 PM Rob Norris @.***> wrote:

Thanks! Looks like you're still working on this. Let me know when it's ready.

— Reply to this email directly, view it on GitHub https://github.com/tpolecat/doobie-http4s-sangria-graphql-example/pull/5#issuecomment-1113520619, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACICCLAPPZVVHUWVUGRB76DVHQHKDANCNFSM5UVSRPAA . You are receiving this because you authored the thread.Message ID: @.*** com>

mariolyon avatar Apr 30 '22 05:04 mariolyon

@tpolecat do you have time to review the PR? thanks

mariolyon avatar May 12 '22 16:05 mariolyon