tpm2-tools icon indicating copy to clipboard operation
tpm2-tools copied to clipboard

Add pcrauth status

Open idesai opened this issue 1 year ago • 5 comments

Fixes #3330 Fixes #3333

idesai avatar Jan 11 '24 23:01 idesai

TODO:

  • [ ] Need to add a test
  • [x] Must implement #3333

idesai avatar Jan 11 '24 23:01 idesai

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (b7e1d2f) 74.38% compared to head (0ae8cee) 73.97%.

Files Patch % Lines
lib/tpm2_util.c 7.04% 66 Missing :warning:
tools/tpm2_pcrsetauthvalue.c 1.53% 64 Missing :warning:
lib/tpm2.c 0.00% 11 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3337      +/-   ##
==========================================
- Coverage   74.38%   73.97%   -0.42%     
==========================================
  Files         173      174       +1     
  Lines       23673    23835     +162     
==========================================
+ Hits        17610    17631      +21     
- Misses       6063     6204     +141     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 12 '24 18:01 codecov[bot]

Hmmmmm... you know that pcrsetauthvalue is forbidden for all PTP compatible TPMs, right ? @idesai What's the use case ?

AndreasFuchsTPM avatar Jan 24 '24 15:01 AndreasFuchsTPM

Hmmmmm... you know that pcrsetauthvalue is forbidden for all PTP compatible TPMs, right ? @idesai What's the use case ?

This is implementing the command spec for TPMs that implement the command.

idesai avatar Jan 25 '24 16:01 idesai

Please add big warnings to the manpage and also to the error printf's that this is not included in PC-Client compatible TPM; indicating that this is actually forbidden for PTP compliant TPMs.

AndreasFuchsTPM avatar Jan 31 '24 09:01 AndreasFuchsTPM