tpm2-tools icon indicating copy to clipboard operation
tpm2-tools copied to clipboard

WIP - CI Multiarch

Open malikabhi05 opened this issue 2 years ago • 1 comments

malikabhi05 avatar Aug 09 '22 23:08 malikabhi05

Codecov Report

Merging #3110 (479d75f) into master (70999b0) will increase coverage by 0.00%. The diff coverage is 93.33%.

@@           Coverage Diff           @@
##           master    #3110   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files         172      172           
  Lines       22668    22688   +20     
=======================================
+ Hits        17321    17338   +17     
- Misses       5347     5350    +3     
Impacted Files Coverage Δ
tools/misc/tpm2_encodeobject.c 74.00% <87.50%> (+0.59%) :arrow_up:
lib/object.c 82.84% <95.45%> (+0.25%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 09 '22 23:08 codecov[bot]

@JuergenReppSIT can you please comment on the failures in fapi tests seen here.

idesai avatar Aug 16 '22 00:08 idesai

@malikabhi05 @idesai Could you please run the tss2_provisioning of one fapi test e.g. fapi-get-random.sh with:

ls -l */* >&2
TSS2_LOG=fapi+trace tss2_provision

The profile, which was not found, should be written to the tmp directory of the test and listed by the ls command. The part of the log to find the profile should be similar to:

trace:fapi:src/tss2-fapi/ifapi_io.c:489:ifapi_io_dirfiles() List directory: /tmp/tpm2_test_ux0guC/tss2_fapi.KWILpL/
...
trace:fapi:src/tss2-fapi/ifapi_io.c:502:ifapi_io_dirfiles() Looking at P_ECCP256SHA256.json 

JuergenReppSIT avatar Aug 16 '22 09:08 JuergenReppSIT

@malikabhi05 @idesai Could you please run the tss2_provisioning of one fapi test e.g. fapi-get-random.sh with:

ls -l */* >&2
TSS2_LOG=fapi+trace tss2_provision

The profile, which was not found, should be written to the tmp directory of the test and listed by the ls command. The part of the log to find the profile should be similar to:

trace:fapi:src/tss2-fapi/ifapi_io.c:489:ifapi_io_dirfiles() List directory: /tmp/tpm2_test_ux0guC/tss2_fapi.KWILpL/
...
trace:fapi:src/tss2-fapi/ifapi_io.c:502:ifapi_io_dirfiles() Looking at P_ECCP256SHA256.json 

This is on the failing build

trace:fapi:src/tss2-fapi/ifapi_io.c:489:ifapi_io_dirfiles() List directory: /tmp/tpm2_test_W77OAn/tss2_fapi.JEKMv5/ ERROR:fapi:src/tss2-fapi/ifapi_profiles.c:116:ifapi_profiles_initialize_async() No files found in profile dir /tmp/tpm2_test_W77OAn/tss2_fapi.JEKMv5/ that match the pattern P_.json ERROR:fapi:src/tss2-fapi/api/Fapi_Initialize.c:283:Fapi_Initialize_Finish() Read profile ErrorCode (0x0006000b) trace:fapi:src/tss2-fapi/api/Fapi_Initialize.c:85:Fapi_Initialize() finished Fapi_Initialize(0x6000B) - fapi:A parameter has a bad value TSS2_LOG=fapi+trace tss2_provision on line 21 failed: 1 ERROR:fapi:src/tss2-fapi/ifapi_profiles.c:116:ifapi_profiles_initialize_async() No files found in profile dir /tmp/tpm2_test_W77OAn/tss2_fapi.JEKMv5/ that match the pattern P_.json ERROR:fapi:src/tss2-fapi/api/Fapi_Initialize.c:283:Fapi_Initialize_Finish() Read profile ErrorCode (0x0006000b) Fapi_Initialize(0x6000B) - fapi:A parameter has a bad value FAIL test/integration/fapi/fapi-get-random.sh (exit status: 1)

idesai avatar Aug 16 '22 21:08 idesai

@JuergenReppSIT we're seeing this on a 32 bit container "ubuntu-20.04.arm32v7"

malikabhi05 avatar Aug 16 '22 21:08 malikabhi05

The problem is caused by the following function calls in ifapi_io_dirfiles

dir = opendir("/tmp/tpm2_test_9XejpY/tss2_fapi.lzKsy4/")
entry = readdir(dir)

readdir does not deliver entries, although files are present in this directory:

/tmp/tpm2_test_9XejpY/tss2_fapi.lzKsy4 total 10264 -rw-r--r-- 1 root root 1020 Aug 17 14:10 P_ECCP256SHA256.json -rw-r--r-- 1 root root 1335 Aug 17 14:10 P_RSA2048SHA256.json

It seems to be a QEMU bug: https://gitlab.com/qemu-project/qemu/-/issues/263

JuergenReppSIT avatar Aug 17 '22 14:08 JuergenReppSIT

load test will pass once #3112 is updated and merged.

malikabhi05 avatar Aug 18 '22 17:08 malikabhi05

@malikabhi05, one small change:

ci: point CI to correct CI repo must be merged into Adding multiarch var The fix in the last commit is for a bug in the same PR.

idesai avatar Aug 31 '22 14:08 idesai