tpm2-tools icon indicating copy to clipboard operation
tpm2-tools copied to clipboard

ci: enable multi-arch builds

Open williamcroberts opened this issue 3 years ago • 9 comments

Signed-off-by: William Roberts [email protected]

williamcroberts avatar Dec 02 '21 16:12 williamcroberts

Codecov Report

Merging #2893 (d1f4ea2) into master (6ff9297) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2893   +/-   ##
=======================================
  Coverage   76.43%   76.43%           
=======================================
  Files         170      170           
  Lines       20965    20965           
=======================================
  Hits        16024    16024           
  Misses       4941     4941           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ff9297...d1f4ea2. Read the comment docs.

codecov[bot] avatar Dec 02 '21 16:12 codecov[bot]

timeout, we might need to do a more compact build/test run on emulated architectures.

williamcroberts avatar Dec 02 '21 17:12 williamcroberts

timeout, we might need to do a more compact build/test run on emulated architectures.

@williamcroberts, should only a successful build suffice?

idesai avatar Jan 14 '22 20:01 idesai

timeout, we might need to do a more compact build/test run on emulated architectures.

@williamcroberts, should only a successful build suffice?

yes

williamcroberts avatar Jan 18 '22 15:01 williamcroberts

@williamcroberts @idesai does "make distcheck" here force the documentation to be generated? I was expecting the build to not generate documentation if pandoc isn't present, however, the build errors out saying You do not have pandoc, a requirement for the distribution of manpages.

Can I replace make distcheck and make distclean with make -jN for multiarch builds or does that cause material problems for the build? :)

malikabhi05 avatar Jun 07 '22 04:06 malikabhi05

@williamcroberts @idesai does "make distcheck" here force the documentation to be generated? I was expecting the build to not generate documentation if pandoc isn't present, however, the build errors out saying You do not have pandoc, a requirement for the distribution of manpages.

Can I replace make distcheck and make distclean with make -jN for multiarch builds or does that cause material problems for the build? :)

Yes distcheck requires pandoc as it's a dist sub-command and to make the distribution tarball you need pandoc.

williamcroberts avatar Jun 07 '22 17:06 williamcroberts

Yes distcheck requires pandoc as it's a dist sub-command and to make the distribution tarball you need pandoc.

I'm removing pandoc from the build in order to speed it up as it is currently timing out. Please let me know if I can use make -jN instead of make distcheck for multiarch builds?

malikabhi05 avatar Jun 07 '22 17:06 malikabhi05

Yes distcheck requires pandoc as it's a dist sub-command and to make the distribution tarball you need pandoc.

I'm removing pandoc from the build in order to speed it up as it is currently timing out. Please let me know if I can use make -jN instead of make distcheck for multiarch builds?

Yeah that would work.

williamcroberts avatar Jun 07 '22 19:06 williamcroberts

The build is now failing due to integration tests here. I keep on seeing the error Could not start simulator at port. Do the integration tests have to be run for multiarch builds?

This is the log

malikabhi05 avatar Jun 07 '22 22:06 malikabhi05

Tracking this in #3110

idesai avatar Aug 16 '22 16:08 idesai