tpm2-pytss icon indicating copy to clipboard operation
tpm2-pytss copied to clipboard

create_primary is missing `TM2B_NAME` in return tuple

Open williamcroberts opened this issue 10 months ago • 4 comments

Its missing the last return parameter that is the TPM2B_NAME, we should add this. @whooo this is probably another one to fix for the release.

williamcroberts avatar May 27 '25 23:05 williamcroberts

The C function doesn't return the name by the looks of it

whooo avatar May 27 '25 23:05 whooo

Interesting.... this seems like a heck of a bug. @AndreasFuchsTPM or @JuergenReppSIT any insights on this?

Image

williamcroberts avatar May 28 '25 00:05 williamcroberts

According to https://trustedcomputinggroup.org/wp-content/uploads/TSS_ESAPI_v1p0_r14_pub10012021.pdf#%5B%7B%22num%22%3A829%2C%22gen%22%3A0%7D%2C%7B%22name%22%3A%22XYZ%22%7D%2C69%2C192%2C0%5D the ESAPI function doesn't return the name, so it seems to be a small difference between SAPI and ESAPI

whooo avatar May 28 '25 00:05 whooo

Ahh probably by design since ESAPI has the function to return a name given an ESYS_TR. @AndreasFuchsTPM was this an intentional design decision or an oversight?

williamcroberts avatar May 28 '25 01:05 williamcroberts