tpm2-openssl icon indicating copy to clipboard operation
tpm2-openssl copied to clipboard

Update Release Flags for Windows build.

Open sushshring opened this issue 1 year ago • 2 comments

The current Release build configuration for Windows generates a MultiThreadedDebugDll. This uses the Debug heap on Windows. When paired with the Release versions of the TSS libraries, there are memory errors since the Release TSS library uses a non-debug heap, and the TPM2-Openssl DLL tries to free from the Debug heap. This change fixes that issue and brings it in line with the TSS library DLLs.

sushshring avatar Feb 01 '24 17:02 sushshring

@gotthardp CI failure but seems to be an infra failure. Can you investigate?

sushshring avatar Feb 01 '24 18:02 sushshring

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (be35c35) 78.17% compared to head (0fb43b0) 78.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files          17       17           
  Lines        2667     2667           
=======================================
  Hits         2085     2085           
  Misses        582      582           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 01 '24 18:02 codecov[bot]